Messages in this thread Patch in this message |  | | | Date | Wed, 14 Jan 2009 13:14:54 +0800 | | From | Li Zefan <> | | Subject | Re: [PATCH] mm: Fix section mismatch in memcontrol.c |
KAMEZAWA Hiroyuki wrote: > On Wed, 14 Jan 2009 10:43:24 +0600 > "Rakib Mullick" <rakib.mullick@gmail.com> wrote: > >> Sure. You can carryout your other jobs. Here is the patch. >> Thanks for your help guys. >> > Thank you. I confirmed this fixes mismatch. > > Could you send this with your Signed-off-by, again ? > > you got my Ack. > Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> >
No... This patch is still not correct..
It's mem_cgroup_create() but not enable_swap_cgroup() that needs to be marked as __init_refok.
Here is the correct one:
=============== From: Li Zefan <lizf@cn.fujitsu.com> Date: Wed, 14 Jan 2009 13:07:31 +0800 Subject: [PATCH] memcg: fix section mismatch
At system boot when creating the top cgroup, mem_cgroup_create() calls enable_swap_cgroup() which is marked as __init, so mark mem_cgroup_create() as __init_refok to avoid false section mismatch warning.
Reported-by: Rakib Mullick <rakib.mullick@gmail.com> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- mm/memcontrol.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index e2996b8..a2c929f 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2181,7 +2181,7 @@ static void __init enable_swap_cgroup(void) } #endif -static struct cgroup_subsys_state * +static struct cgroup_subsys_state * __init_refok mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont) { struct mem_cgroup *mem, *parent; -- 1.5.4.rc3
|  |