Messages in this thread | | | Subject | Re: [PATCH] lib/idr.c: Zero memory properly in idr_remove_all | From | Kristian Høgsberg <> | Date | Wed, 14 Jan 2009 11:33:22 -0500 |
| |
On Wed, 2009-01-14 at 17:21 +0100, Stefan Richter wrote: > Kristian Høgsberg wrote: > > On Tue, 2009-01-13 at 14:48 -0800, Andrew Morton wrote: > >> What do we think of just removing the constructor and using > >> kmem_cache_zalloc()? > > > > We still need to zero out the idr_layer before returning it to the idr's > > internal free list. > > I think so too. But a more robust solution would IMO be to initialize > an idr_layer /before/ use, not /after/ use. Will send a patch later.
The reason it was done this way is that normally, when the layers are returned to the free list they're already zero'ed out (since their elements have been removed one by one), so no need to do this on later re-initialization or when freeing. It's a silly little sup-optimization. idr_remove_all() is different in that it doesn't incrementally zero out the layer, and so it has to do it using a memset.
If you want rework how this works, I'd suggest just not using the free list except for in the idr_pre_get()+idr_get() sequence. When a layer is no longer used, just free it, don't put it back on the free list. And use kmem_cache_zalloc() in idr_pre_get() as Andrew suggests.
cheers, Kristian
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |