![]() | |||||||||||||
Messages in this thread |
On Sun, Jan 11, 2009 at 12:11:27AM +0100, Ingo Molnar wrote:
>
> * Joerg Roedel <joerg.roedel@amd.com> wrote:
>
> > +#define err_printk(dev, format, arg...) do { \
> > + error_count += 1; \
> > + if (show_all_errors || show_num_errors > 0) { \
> > + WARN(1, "%s %s: " format, \
> > + dev_driver_string(dev), \
> > + dev_name(dev) , ## arg); \
> > + } \
> > + if (!show_all_errors && show_num_errors > 0) \
> > + show_num_errors -= 1; \
>
> Note that the arithmetics here is SMP-unsafe: we only hold the hash bucket
> so if two errors hit at once on two CPUs then the error tracking variables
> can be accessed at once.
>
> I'd suggest a simple global lock for this error case (taken inside the
> hash bucket lock), to be on the safe side.
As I wrote in a previous email, a race here is no big deal. I add a
comment to document it. Or do we want another global lock here?
> Also, please dont use a macro for this - printk details can be passed in
> to helper inlines/functions too.
Hmm, how does this look like? There is not WARN variant which can use
va_args as a parameter. And it is important that the error message is
logged in the warning itself. So the driver developer can see it when a
user reports the warning.
Joerg
--
| Advanced Micro Devices GmbH
Operating | Karl-Hammerschmidt-Str. 34, 85609 Dornach bei München
System |
Research | Geschäftsführer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
| Registergericht München, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
| ||||||||||||
| Last update: 2009-01-14 12:47 [from the cache] ©2003-2008 | |||||||||||||