Messages in this thread | | | Date | Tue, 13 Jan 2009 18:48:43 -0800 | Subject | Re: [RFC][PATCH 4/4] cgroup-memcg fix frequent EBUSY at rmdir | From | Paul Menage <> |
| |
On Thu, Jan 8, 2009 at 1:35 AM, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote: > + if (ret == -EAGAIN) { /* subsys asks us to retry later */ > + mutex_unlock(&cgroup_mutex); > + cond_resched(); > + goto retry; > + }
This spinning worries me a bit. It might be better to do an interruptible sleep until the relevant CSS's refcount goes down to zero. And is there no way that the memory controller can hang on to a reference indefinitely, if the cgroup still has some pages charged to it?
Paul
| |