lkml.org 
[lkml]   [2009]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -tip] coda_psdev.h: extern's make no sense in userspace
From
Date
On Tue, 2009-01-13 at 12:06 +0530, Jaswinder Singh Rajput wrote:
> Impact: fix make headers_check warning:
>
> usr/include/linux/coda_psdev.h:90: extern's make no sense in userspace
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> include/linux/coda_psdev.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/coda_psdev.h b/include/linux/coda_psdev.h
> index 07ae8f8..c620958 100644
> --- a/include/linux/coda_psdev.h
> +++ b/include/linux/coda_psdev.h
> @@ -87,6 +87,8 @@ struct upc_req {
> * Statistics
> */
>
> +#ifdef __KERNEL__
> extern struct venus_comm coda_comms[];
> +#endif /* __KERNEL__ */

As this only gets used in code/inode.c, coda/psdev.c it would be nice if
a code-internal header could be found that could hold this.

This is only here due to the one use outside of psdev.c in inode.c

Harvey



\
 
 \ /
  Last update: 2009-01-13 08:25    [W:0.046 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site