lkml.org 
[lkml]   [2009]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] tcp: splice as many packets as possible at once
    David Miller a écrit :
    > From: Eric Dumazet <dada1@cosmosbay.com>
    > Date: Fri, 09 Jan 2009 08:28:09 +0100
    >
    >> If the application uses setsockopt(sock, SOL_SOCKET, SO_RCVLOWAT,
    >> [32768], 4), it would be good if kernel was smart enough and could
    >> reduce number of wakeups.
    >
    > Right, and as I pointed out in previous replies the problem is
    > that splice() receive in TCP doesn't check the low water mark
    > at all.
    >
    >

    Yes I understand, but if splice() is running, wakeup occured, and
    no need to check if the wakeup was good or not... just proceed and
    consume some skb, since we already were awaken.

    Then, an application might setup a high SO_RCVLOWAT, but want to splice()
    only few bytes, so RCVLOWAT is only a hint for the thing that perform the
    wakeup, not for the consumer.


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-01-14 00:41    [W:0.024 / U:30.616 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site