Messages in this thread | | | Date | Wed, 14 Jan 2009 01:04:01 +0300 | From | Evgeniy Polyakov <> | Subject | Re: Linux killed Kenny, bastard! |
| |
Hi.
On Wed, Jan 14, 2009 at 01:35:36AM +0900, KOSAKI Motohiro (kosaki.motohiro@jp.fujitsu.com) wrote: > > + /* > > + * We did not find the process with requested string in its name, > > + * so lets search for the usual victim. > > + */ > > + if (name && !chosen) { > > + name = NULL; > > + goto again; > > + } > > + > > return chosen; > > this patch makes oom handling slower. > slow bad process selection cause next another out of memory. > > then, your trouble become large.
It really does not. As I described, when task does not have a valid name, all checks are skipped.
So effectively it equals to the additional check in the loop, which although being non-zero, but really is very small, since most of the time process does not match and only single letter of the name should be checked.
-- Evgeniy Polyakov
| |