lkml.org 
[lkml]   [2009]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: Fix section mismatch in memcontrol.c
On Tue, 13 Jan 2009 13:49:03 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:

> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
>
> Rakib Mullick wrote:
> > Impact: Fix section mismatch warning.
> >
> > The annotation for __init in enable_swap_cgroup() and __initdata for
> > really_do_swap_account produces the following warning. Which is not
> > right, since this function is called from non-init section. This patch
> > fixes it. If anything else please notice.
> >
>
> I saw this warning on IA64. But this fix is wrong IMO.
>
> enable_swap_cgroup() will be called at system boot only:
>
> start_kernel()
> cgroup_init()
> mem_cgroup_create()
> enable_swap_cgroup()
>
> I think the proper fix is annotate mem_cgroup_create() with __init_refok.
>
I think Li Zefan's fix is correct.
Could you make a patch ? or I'll schedule this as my work.

Thanks,
-Kame




\
 
 \ /
  Last update: 2009-01-13 07:19    [W:0.067 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site