lkml.org 
[lkml]   [2009]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: new barrier warnings in 2.6.29-rc1
Hello, Jens.

Jens Axboe wrote:
> On Tue, Jan 13 2009, Tejun Heo wrote:
>> I think the right thing to do is setting REQ_QUIET on the trial
>> barrier request.
>
> It would surely work, but XFS doesn't really have a way to do that. Then
> we would have to add a bio quiet flag and inherit that.
>
> I kind of liked the old behaviour. What about something like the below?
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index a824e49..eddba4a 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -1448,6 +1448,11 @@ static inline void __generic_make_request(struct bio *bio)
> err = -EOPNOTSUPP;
> goto end_io;
> }
> + if (bio_barrier(bio) && bio_has_data(bio) &&
> + (q->next_ordered == QUEUE_ORDERED_NONE)) {
> + err = -EOPNOTSUPP;
> + goto end_io;
> + }
>
> ret = q->make_request_fn(q, bio);
> } while (ret);

I have no objection against it. I kind of like having single test
point but it's a corner case anyway so no biggie.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-01-13 11:47    [W:0.217 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site