lkml.org 
[lkml]   [2009]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: linux-next: origin tree build failure
    From
    Date
    On Mon, 2009-01-12 at 10:05 +0100, Ingo Molnar wrote:
    > * Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
    >
    > > On Mon, 2009-01-12 at 10:48 +1100, Stephen Rothwell wrote:
    > > > Hi Linus,
    > > >
    > > > Today's linux-next build (powerpc ppc64_defconfig) failed like this:
    > > >
    > > > arch/powerpc/platforms/pasemi/cpufreq.c: In function 'pas_cpufreq_cpu_init':
    > > > arch/powerpc/platforms/pasemi/cpufreq.c:216: error: incompatible types in assignment
    > > > arch/powerpc/platforms/powermac/cpufreq_64.c: In function 'g5_cpufreq_cpu_init':
    > > > arch/powerpc/platforms/powermac/cpufreq_64.c:365: error: incompatible types in assignment
    > > > arch/powerpc/platforms/cell/cbe_cpufreq.c: In function 'cbe_cpufreq_cpu_init':
    > > > arch/powerpc/platforms/cell/cbe_cpufreq.c:121: error: incompatible types in assignment
    > > >
    > > > Caused by commit 835481d9bcd65720b473db6b38746a74a3964218 ("cpumask:
    > > > convert struct cpufreq_policy to cpumask_var_t") which missed updating
    > > > all the powerpc (at least) cpufreq drivers.
    > >
    > > Yeah, it only updates x86 it seems ...
    >
    > Yeah - and that build bug was stupid too - when touching a generic file
    > that is called include/linux/cpufreq.h and changing a key data field one
    > should at minimum get the idea that it's generic for a reason and should
    > start grepping the tree ...
    >
    > It slipped through because it didnt get caught in build tests because
    > cpufreq isnt enabled in the powerpc defconfig.

    Which defconfig?

    powerpc(master) $ git grep CPU_FREQ=y arch/powerpc/configs/ppc64_defconfig
    arch/powerpc/configs/ppc64_defconfig:CONFIG_CPU_FREQ=y

    cheers

    --
    Michael Ellerman
    OzLabs, IBM Australia Development Lab

    wwweb: http://michael.ellerman.id.au
    phone: +61 2 6212 1183 (tie line 70 21183)

    We do not inherit the earth from our ancestors,
    we borrow it from our children. - S.M.A.R.T Person
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2009-01-12 10:53    [W:0.025 / U:0.256 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site