lkml.org 
[lkml]   [2009]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH] move spitz-keyboard's probe function to .devinit.text
    A pointer to spitzkbd_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    ---
    drivers/input/keyboard/spitzkbd.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/input/keyboard/spitzkbd.c b/drivers/input/keyboard/spitzkbd.c
    index c48b76a..f82fb9d 100644
    --- a/drivers/input/keyboard/spitzkbd.c
    +++ b/drivers/input/keyboard/spitzkbd.c
    @@ -343,7 +343,7 @@ static int spitzkbd_resume(struct platform_device *dev)
    #define spitzkbd_resume NULL
    #endif

    -static int __init spitzkbd_probe(struct platform_device *dev)
    +static int __devinit spitzkbd_probe(struct platform_device *dev)
    {
    struct spitzkbd *spitzkbd;
    struct input_dev *input_dev;
    --
    1.5.6.5
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-01-12 23:49    [W:0.022 / U:1.888 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site