lkml.org 
[lkml]   [2009]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] [RESEND] tracing: Add a new workqueue tracer

    On Mon, 12 Jan 2009, Frederic Weisbecker wrote:
    > > WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(),
    > > num_possible_cpus(), for_each_possible_cpu(), etc
    > > #953: FILE: kernel/trace/trace_workqueue.c:153:
    > > + for (i = 0; i < NR_CPUS; i++) {
    > >
    > > We should probably change them to for_each_possible_cpu, or online cpu.
    > >
    > > -- Steve
    >
    >
    > I found it very convenient because I didn't have to allocate
    > my cpu list array dynamically with it :-)
    >
    > I'm preparing a v2...
    >

    Thanks!

    -- Steve



    \
     
     \ /
      Last update: 2009-01-12 21:03    [W:0.021 / U:30.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site