Messages in this thread | | | Date | Mon, 12 Jan 2009 11:47:13 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [git pull] x86 fixes |
| |
On Mon, 12 Jan 2009, Pallipadi, Venkatesh wrote: > + if (strict_prot || > + (want_flags == _PAGE_CACHE_UC_MINUS && > + flags == _PAGE_CACHE_WB) || > + (want_flags == _PAGE_CACHE_WC && > + flags == _PAGE_CACHE_WB)) {
Please don't write code like this.
Do it as an inline function that returns true/false and has comments on what the hell is going on.
If a conditional doesn't fit on one line, it should generally be abstracted away into a readable function where the name explains what it does conceptually.
Linus
| |