lkml.org 
[lkml]   [2009]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]: xen: fix too early kmalloc call

* Mike Travis <travis@sgi.com> wrote:

> > i've applied the fix to tip/cpus4096, in the form below.
> >
> > Please submit clean log messages. Your commit description was confused
> > - the patch is From: Christophe, but the message talks about
> > Christophe in the third person. Also, it included conversational bits
> > that have no value for the Git history.
> >
> > Ingo
>
> Ahh, ok, will do. I wasn't sure how many "liberties" we can take in
> submitting/changing something from someone else.

You are free to perfect anyone's commit log in essence - i do it for 90%
of all commits that go via -tip. I fix tyops and grammar mistaiks in every
second commit, and have to fix basic formatting, structure, explanations
and reported-by credits and tags in most of them. Submitting patches with
a well-structured commit log gives you extra credit :-)

[ Obviously you are not free to make a commit log worse and then make it
appear as if the guy who submitted it did it ;-) ]

Ingo


\
 
 \ /
  Last update: 2009-01-12 20:17    [W:0.050 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site