Messages in this thread | | | Date | Mon, 12 Jan 2009 20:13:32 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH]: xen: fix too early kmalloc call |
| |
* Mike Travis <travis@sgi.com> wrote:
> > i've applied the fix to tip/cpus4096, in the form below. > > > > Please submit clean log messages. Your commit description was confused > > - the patch is From: Christophe, but the message talks about > > Christophe in the third person. Also, it included conversational bits > > that have no value for the Git history. > > > > Ingo > > Ahh, ok, will do. I wasn't sure how many "liberties" we can take in > submitting/changing something from someone else.
You are free to perfect anyone's commit log in essence - i do it for 90% of all commits that go via -tip. I fix tyops and grammar mistaiks in every second commit, and have to fix basic formatting, structure, explanations and reported-by credits and tags in most of them. Submitting patches with a well-structured commit log gives you extra credit :-)
[ Obviously you are not free to make a commit log worse and then make it appear as if the guy who submitted it did it ;-) ]
Ingo
| |