Messages in this thread | | | Date | Sun, 11 Jan 2009 21:29:49 +1100 | From | Paul Mackerras <> | Subject | Re: [PATCH] net: ppp_generic - fix broken userspace |
| |
David Miller writes:
> PPP was converted to use IDR instead of PPP's duplicate > implementation. > > A bug was introduced in that conversion, and that bug is being fixed > here. > > What is not to like? :-)
Ah OK, that sounds all right. I was reacting to the "broken userspace" in the patch description which at first glance seemed to be saying that userspace (i.e. pppd :) is doing something which has recently been declared to be wrong and therefore it is "broken".
I think "fix broken userspace" as a patch headline is quite ambiguous. Something like "Fix bug in conversion to use IDR" would be more informative.
Paul.
| |