Messages in this thread | | | Date | Sun, 11 Jan 2009 09:00:19 +0100 | From | Joerg Roedel <> | Subject | Re: [PATCH 14/16] dma-debug: add checks for sync_single_sg_* |
| |
On Sun, Jan 11, 2009 at 12:46:41AM +0100, Ingo Molnar wrote: > > * Joerg Roedel <joerg.roedel@amd.com> wrote: > > > +void debug_sync_sg_for_cpu(struct device *dev, struct scatterlist *sg, > > + int nelems, int direction) > > +{ > > + struct scatterlist *s; > > + int i; > > + > > + if (global_disable) > > + return; > > "if (unlikely(global_disable))" i suspect?
True. I will add unlikely() to all global_disable checks.
Joerg
| |