lkml.org 
[lkml]   [2009]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: Build error on latest git
    From
    Date
    On Sun, 2009-01-11 at 18:36 +0530, Jaswinder Singh Rajput wrote:
    > On Sun, Jan 11, 2009 at 5:27 PM, Petr Titera <P.Titera@century.cz> wrote:
    > > Going through source it seems to me (still building) that it is caused by
    > > including asm/smp.h only if build with CONFIG_SMP. This patch seems to fix
    > > this
    > >
    > > diff --git a/include/linux/smp.h b/include/linux/smp.h
    > > index b824669..fd51bb9 100644
    > > --- a/include/linux/smp.h
    > > +++ b/include/linux/smp.h
    > > @@ -11,6 +11,8 @@
    > > #include <linux/list.h>
    > > #include <linux/cpumask.h>
    > >
    > > +#include <asm/smp.h>
    > > +
    > > extern void cpu_idle(void);
    > >
    >
    > No, this is wrong.
    >
    > asm/smp.h should only be included when CONFIG_SMP is defined.
    >
    > I will send fix of this.
    >

    Here is the temporary fix, later on I will remove non-smp data from
    smp.h

    Subject: [PATCH] x86: mpparse.c fix compilation error

    Impact: fix compilation error

    Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
    ---
    arch/x86/kernel/mpparse.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
    index 8385d4e..79dae60 100644
    --- a/arch/x86/kernel/mpparse.c
    +++ b/arch/x86/kernel/mpparse.c
    @@ -27,6 +27,7 @@
    #include <asm/e820.h>
    #include <asm/trampoline.h>
    #include <asm/setup.h>
    +#include <asm/smp.h>

    #include <mach_apic.h>
    #ifdef CONFIG_X86_32
    --
    1.5.6.6




    \
     
     \ /
      Last update: 2009-01-11 14:13    [W:0.020 / U:0.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site