Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] cpumask fallout: Initialize irq_default_affinity earlier. | Date | Sat, 10 Jan 2009 15:41:13 +1030 |
| |
On Friday 09 January 2009 07:26:59 Linus Torvalds wrote: > > On Thu, 8 Jan 2009, David Daney wrote: > > > > The 'inline' seems gratuitous to me. Since it is static GCC should do > > the Right Thing. However since you suggested it, I am testing it that > > way. > > Trust me, gcc very seldom does the Right Thing(tm) when it comes to > inlining. > > Linus
Note that there's a downside: with inline funcs in .c files you don't get a warning should they become unused in future cleanups.
Cheers, Rusty.
| |