| | Date | Sun, 11 Jan 2009 00:08:26 +0100 | | From | Ingo Molnar <> | | Subject | Re: [PATCH 07/16] dma-debug: add debugfs interface |
* Joerg Roedel <joerg.roedel@amd.com> wrote:
> +/* Global error count */
> +static u32 error_count;
> +
> +/* Global error show enable*/
> +static u32 show_all_errors __read_mostly;
> +/* Number of errors to show */
> +static u32 show_num_errors = 1;
> +
> static u32 num_free_entries;
> static u32 min_free_entries;
Small detail: please use native C types for non-hardware variables -
'unsigned int', 'unsigned long', etc.
u32/u64 is typically used for variables where there is a real significance
to the precise width of the variable: there's either a hardware or a
user-space ABI involved.
Ingo
|