lkml.org 
[lkml]   [2008]   [Sep]   [9]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateTue, 9 Sep 2008 09:22:16 +0200
FromPierre Ossman <>
SubjectRe: [RFC][PATCH] MMC: Use write timeout value as read from CSR
On Mon, 8 Sep 2008 14:28:00 +0100
"Matt Fleming" <mattjfleming@googlemail.com> wrote:

> 2008/9/7 Pierre Ossman <drzeus-mmc@drzeus.cx>:
> >
> > This actually isn't fully correct for SD either as it only specifies
> > that 250 ms is the upper bound on the timeout.
> >
> > I believe the proper way of solving this is to have mmc_spi respect the
> > timeouts set in the request structure. Modify mmc_set_data_timeout() if
> > necessary.
> >
> 
> You're right, I changed the patch accordingly (I also fixed the read
> timeout path).
> 

This still doesn't use the fields from the request structure. E.g. SDIO
support is probably still broken here as it mandates a timeout of 1
second for data transfers.

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.


\
 
 \ /
  Last update: 2008-09-09 09:25    [from the cache]
©2003-2008