lkml.org 
[lkml]   [2008]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs
    On Sun, Sep 7, 2008 at 9:20 PM, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
    > On Mon, Sep 8, 2008 at 4:24 AM, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
    >> On Sat, Sep 6, 2008 at 6:12 AM, Ingo Molnar <mingo@elte.hu> wrote:
    >>>
    >>> * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
    >>>
    >>>> By changing printout form we are able to shrink code a bit.
    >>>>
    >>>> Former printout example:
    >>>>
    >>>> init IO_APIC IRQs
    >>>> IO-APIC (apicid-pin) 1-1, 1-2, 1-3 not connected.
    >>>> IO-APIC (apicid-pin) 2-1, 2-2, 2-3 not connected.
    >>>>
    >>>> New printout example:
    >>>>
    >>>> init IO_APIC IRQs
    >>>> 1-1 1-2 1-3 (apicid-pin) not connected
    >>>> 2-1 2-2 2-3 (apicid-pin) not connected
    >>>
    >>> applied to tip/irq/sparseirq - thanks Cyrill.
    >>
    >> got
    >> 0-16<7> 0-17<7> 0-18<7> 0-19<7> 0-20<7> 0-21<7> 0-22<7> 0-23<7>
    >> (apicid-pin) not connected
    >> 1-0<7> 1-1<7> 1-2<7> 1-3<7> 1-4<7> 1-5<7> 1-6<7> 1-7<7> 1-8<7> 1-9<7>
    >> 1-10<7> 1-11<7> 1-12<7> 1-13<7> 1-14<7> 1-15<7> 1-16<7> 1-17<7>
    >> 1-18<7> 1-19<7> 1-20<7> 1-21<7> 1-22<7> 1-23<7> (apicid-pin) not
    >> connected
    >>
    >> can you remove the extra <7>?
    >>
    >> YH
    >>
    >
    > Btw Yinghai, do you really have a machine with that many unconnected pins?

    Yes

    recent change in sparseirq, we only init irq [0,16) at that point. so
    pins on other io apic controller all unconnected...

    YH


    \
     
     \ /
      Last update: 2008-09-08 06:41    [W:0.025 / U:59.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site