lkml.org 
[lkml]   [2008]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] swiotlb: remove GFP_DMA hack in swiotlb_alloc_coherent
On Mon, Sep 08, 2008 at 06:10:14PM +0900, FUJITA Tomonori wrote:
> The callers are supposed to set up the gfp flags appropriately.
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>

Acked-by: Joerg Roedel <joerg.roedel@amd.com>

> ---
> lib/swiotlb.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/lib/swiotlb.c b/lib/swiotlb.c
> index 977edbd..3066ffe 100644
> --- a/lib/swiotlb.c
> +++ b/lib/swiotlb.c
> @@ -467,13 +467,6 @@ swiotlb_alloc_coherent(struct device *hwdev, size_t size,
> void *ret;
> int order = get_order(size);
>
> - /*
> - * XXX fix me: the DMA API should pass us an explicit DMA mask
> - * instead, or use ZONE_DMA32 (ia64 overloads ZONE_DMA to be a ~32
> - * bit range instead of a 16MB one).
> - */
> - flags |= GFP_DMA;
> -
> ret = (void *)__get_free_pages(flags, order);
> if (ret && address_needs_mapping(hwdev, virt_to_bus(ret))) {
> /*
> --
> 1.5.5.GIT
>
>

--
| AMD Saxony Limited Liability Company & Co. KG
Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
System | Register Court Dresden: HRA 4896
Research | General Partner authorized to represent:
Center | AMD Saxony LLC (Wilmington, Delaware, US)
| General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy



\
 
 \ /
  Last update: 2008-09-08 14:05    [W:0.106 / U:7.496 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site