lkml.org 
[lkml]   [2008]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] ti_usb_3410_5052 obviously broken by firmware changes
From: Chris Adams <cmadams@hiwaay.net>

While making some other changes to ti_usb_3410_5052, I noticed that the
changes made to move the firmware loading to a separate function are
broken (in ti_download_firmware(), status is set to -ENOMEM and never
changed). This means the driver will never initialize the device
properly. It looks like status was supposed to get the result of
ti_do_download().

Signed-off-by: Chris Adams <cmadams@hiwaay.net>
---
It doesn't look like there's a maintainer for this driver other than TI
(which has no email listed). Should changes for this go to linux-usb,
here, or what?


diff -urpN linux-2.6.27-rc5-git9-vanilla/drivers/usb/serial/ti_usb_3410_5052.c linux-2.6.27-rc5-git9/drivers/usb/serial/ti_usb_3410_5052.c
--- linux-2.6.27-rc5-git9-vanilla/drivers/usb/serial/ti_usb_3410_5052.c 2008-09-08 20:57:56.000000000 -0500
+++ linux-2.6.27-rc5-git9/drivers/usb/serial/ti_usb_3410_5052.c 2008-09-08 21:02:13.000000000 -0500
@@ -1744,7 +1744,7 @@ static int ti_download_firmware(struct t
if (buffer) {
memcpy(buffer, fw_p->data, fw_p->size);
memset(buffer + fw_p->size, 0xff, buffer_size - fw_p->size);
- ti_do_download(dev, pipe, buffer, fw_p->size);
+ status = ti_do_download(dev, pipe, buffer, fw_p->size);
kfree(buffer);
}
release_firmware(fw_p);


\
 
 \ /
  Last update: 2008-09-09 04:39    [W:0.025 / U:4.484 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site