[lkml]   [2008]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] TTY: Fix loss of echoed characters (2nd follow-on PATCH attached)
On Mon, 08 Sep 2008 10:11:46 -0600
Joe Peterson <> wrote:

> + spin_lock_irqsave(&tty->echo_lock, flags);
> lock_kernel();

Taking a spinlock outside lock_kernel() isn't good, and is quite unusual.

- It might be ab/ba deadlockable (I didn't check) (I trust you always
test with lockdep enabled?)

- will make Ingo unhappy when he applies his "make lock_kernel use
mutex_lock" patch (if it's still around).

- will probably give the -rt guys conniptions.

swapping the above two lines would presumably be an easy fix, but one
wonders whether we still need lock_kernel() in there once you've added
this lock.

 \ /
  Last update: 2008-09-09 02:35    [W:0.077 / U:2.584 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site