lkml.org 
[lkml]   [2008]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] hfs: fix namelength memory corruption
On Mon, 8 Sep 2008 15:35:05 +0200
Eric Sesterhenn <snakebyte@gmx.de> wrote:

> hi,
>
> this is basically the same as
> hfsplus-fix-buffer-overflow-with-a-corrupted-image.patch.

I can't really use the above text in a changelog. Think how it will
look in git in two years time.

> We use the length parameter for a memcopy without checking it and
> thereby corruption memory.

"corrupting".

I assume that this bug was found using a deliberately corrupted
filesystem? If so, that sort of thing should be described in the
changelog.

Please spend a little more time (say, 60 seconds) preparing patch
descriptions.


> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> --- linux/fs/hfs/catalog.c.orig 2008-09-08 15:20:15.000000000 +0200
> +++ linux/fs/hfs/catalog.c 2008-09-08 15:21:02.000000000 +0200
> @@ -190,6 +190,10 @@ int hfs_cat_find_brec(struct super_block
>
> fd->search_key->cat.ParID = rec.thread.ParID;
> len = fd->search_key->cat.CName.len = rec.thread.CName.len;
> + if (len > HFS_NAMELEN) {
> + printk(KERN_ERR "hfs: bad catalog namelength\n");
> + return -EIO;
> + }
> memcpy(fd->search_key->cat.CName.name, rec.thread.CName.name, len);
> return hfs_brec_find(fd);
> }

Please send a full changelog for this patch.

I can (and often do) end up writing these things myself, but it's not a
very satisfactory arrangement, particularly when I'm not provided with
sufficient information to do so.

Thanks.


\
 
 \ /
  Last update: 2008-09-09 02:17    [W:0.035 / U:2.500 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site