lkml.org 
[lkml]   [2008]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] PCI: vpd handle longer delays in access
On Mon, 8 Sep 2008 13:40:25 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Thu, 04 Sep 2008 13:56:37 -0700
> Stephen Hemminger <shemminger@vyatta.com> wrote:
>
> > Accessing the VPD area can take a long time. The existing
> > VPD access code fails consistently on my hardware. There are comments
> > in the SysKonnect vendor driver that it can take up to 13ms per word.
> >
> > Change the access routines to:
> > * use a mutex rather than spinning with IRQ's disabled and lock held
> > * have a longer timeout
> > * call schedule while spinning to provide some responsivness
>
> It doesn't call schedule() - it calls yield().
>
> yield() is pretty notoriously badly behaved in the presence of lots of
> runnable tasks and there's been a general move to eradicate its
> in-kernel callsites.
>
> An alternative would be nice.

What is a good way to say "i am polling for a while"?


\
 
 \ /
  Last update: 2008-09-08 23:11    [W:0.096 / U:0.044 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site