lkml.org 
[lkml]   [2008]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 11/13] genapic: reduce stack pressuge in io_apic.c step 3 target_cpus
Ingo Molnar wrote:
>>> +#ifdef CONFIG_X86_64
>>> +#define TARGET_CPUS(retval) (genapic->target_cpus)(&(retval))
>>> +#else
>>> +#define TARGET_CPUS(retval) retval = (genapic->target_cpus())
>>> +#endif
>
> hm, this should be unified.
>
> Ingo

As I did that one first, I didn't want to muddle through too much i386 code,
but when I did the vector_allocation_domain, it became more clear that making
them common would be better.

I also tripped myself up because one of my test i386 configs had 64 cpus and
it fired up the "NR_CPUS > BITS_PER_LON" code. ;-) [And I'm supposing it's
probably justified to believe that there may be "fairly large" 32-bit systems,
for those applications that need horsepower but not a lot of memory.]

Thanks,
Mike


\
 
 \ /
  Last update: 2008-09-08 17:05    [W:0.099 / U:3.392 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site