lkml.org 
[lkml]   [2008]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH v2 0/7] Tunable sched_mc_power_savings=n
From
Date
On Mon, 2008-09-08 at 19:18 +0530, Vaidyanathan Srinivasan wrote:
> * Peter Zijlstra <a.p.zijlstra@chello.nl> [2008-09-08 15:25:46]:
>
> > May I again ask to first clean up the current power saving code before
> > stacking more on top of it?
>
> :) I understand that you have asked for two things with respect to the
> current power save balance code:
>
> 1. Detailed documentation

Preferably in the form of in-code comments and code structure, this
Documentation/* stuff always gets lost on me.

> 2. Cleanup the group_min and group_leader stuff in
> find_busiest_group()
>
> Did I get the requirements correct?

That would be much appreciated.

But I also prefer to get rid of that power savings tweak in
cpu_coregroup_map().

But above all, readable code ;-)

find_busiest_group() is the stuff of nightmares.



\
 
 \ /
  Last update: 2008-09-08 15:59    [W:0.091 / U:1.324 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site