lkml.org 
[lkml]   [2008]   [Sep]   [7]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateSun, 07 Sep 2008 17:03:23 -0700
FromJeremy Fitzhardinge <>
SubjectRe: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table
Andi Kleen wrote:
> On Sun, Sep 07, 2008 at 03:21:18PM -0700, Jeremy Fitzhardinge wrote:
> 
>> __acpi_map_table() effectively reimplements early_ioremap().  Rather
>> than have that duplication, just implement it in terms of
>> early_ioremap().
>>
>> However, unlike early_ioremap(), __acpi_map_table() just maintains a
>> single mapping which gets replaced each call, and has no corresponding
>> unmap function.  Implement this by just removing the previous mapping
>> each time its called.  Unfortunately, this will leave a stray mapping
>> at the end.
>> 
>
> It would be better to just fix the ACPI code to unmap.

I was concerned that would cause lots of cross-arch churn, but of course
the only other relevant architecture is ia64.  I'll prep a followup patch.

    J


\
 
 \ /
  Last update: 2008-09-08 02:05    [from the cache]
©2003-2008