lkml.org 
[lkml]   [2008]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateSat, 6 Sep 2008 10:16:39 -0700
From"Yinghai Lu" <>
SubjectRe: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol
On Sat, Sep 6, 2008 at 10:09 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Andrew Morton <akpm@linux-foundation.org> wrote:
>
>> > ptr = __alloc_bootmem_nopanic(total_size, max_align, 0);
>> > if (!ptr)
>> > panic("Can not alloc dyn_alloc\n");
>>
>> Why duplicate the panic()? Just call __alloc_bootmem().
>
> agreed.
>
>> > #ifdef CONFIF_GENERIC_HARDIRQS
>>
>> That doesn't appear to have been very well tested?
>
> on non-genirq systems? Most likely. If then most testing they get is
> from cross-build tools. Few if any actual users.
>
>> The code has a few coding-style glitches which checkpatch can detect.
>
> yeah. Yinghai, could you please fix them?

already in tip/master and -mm
except first one.

YH


\
 
 \ /
  Last update: 2008-09-06 19:19    [from the cache]
©2003-2010