[lkml]   [2008]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol

* Andrew Morton <> wrote:

> > ptr = __alloc_bootmem_nopanic(total_size, max_align, 0);
> > if (!ptr)
> > panic("Can not alloc dyn_alloc\n");
> Why duplicate the panic()? Just call __alloc_bootmem().


> That doesn't appear to have been very well tested?

on non-genirq systems? Most likely. If then most testing they get is
from cross-build tools. Few if any actual users.

> The code has a few coding-style glitches which checkpatch can detect.

yeah. Yinghai, could you please fix them?


 \ /
  Last update: 2008-09-06 19:13    [W:0.062 / U:0.808 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site