Messages in this thread | | | Date | Sat, 06 Sep 2008 19:08:28 +0200 | From | Manfred Spraul <> | Subject | Re: [PATCH] kernel/cpu.c: Move the CPU_DYING notifiers |
| |
Ingo Molnar wrote: > * Manfred Spraul <manfred@colorfullife.com> wrote: > >> - raw_notifier_call_chain(&cpu_chain, CPU_DYING | param->mod, >> - param->hcpu); >> /* Ensure this CPU doesn't handle any more interrupts. */ >> err = __cpu_disable(); >> if (err < 0) >> return err; >> >> + raw_notifier_call_chain(&cpu_chain, CPU_DYING | param->mod, >> + param->hcpu); >> > > hm, doesnt this break things like CPU cross-calls done in CPU_DYING > callbacks? > We are within stop_machine(). No other cpu is running. As fas as I can see no cross-calls are possible.
Which scenario do you think about?
-- Manfred
| |