Messages in this thread | | | Date | Fri, 5 Sep 2008 22:23:20 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] Add missing macro argument for devm_release_* family |
| |
On Sat, 06 Sep 2008 08:18:41 +0300 (EEST) Hiroshi DOYU <Hiroshi.DOYU@nokia.com> wrote:
> From: "ext Andrew Morton" <akpm@linux-foundation.org> > Subject: Re: [PATCH] Add missing macro argument for devm_release_* family > Date: Fri, 5 Sep 2008 18:52:54 -0700 > > > On Sat, 6 Sep 2008 04:00:23 +0300 Hiroshi DOYU <Hiroshi.DOYU@nokia.com> wrote: > > > > > From: ext Hiroshi DOYU <Hiroshi.DOYU@nokia.com> > > > > > > Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com> > > > --- > > > include/linux/ioport.h | 4 ++-- > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/include/linux/ioport.h b/include/linux/ioport.h > > > index 22d2115..c813c63 100644 > > > --- a/include/linux/ioport.h > > > +++ b/include/linux/ioport.h > > > @@ -158,9 +158,9 @@ extern struct resource * __devm_request_region(struct device *dev, > > > struct resource *parent, resource_size_t start, > > > resource_size_t n, const char *name); > > > > > > -#define devm_release_region(start,n) \ > > > +#define devm_release_region(dev,start,n) \ > > > __devm_release_region(dev, &ioport_resource, (start), (n)) > > > -#define devm_release_mem_region(start,n) \ > > > +#define devm_release_mem_region(dev,start,n) \ > > > __devm_release_region(dev, &iomem_resource, (start), (n)) > > > > > > extern void __devm_release_region(struct device *dev, struct resource *parent, > > > > um, OK. > > > > But none of these things appear to have any callers anywhere. Why > > don't we just delete it all? > > Not sure for others, but at least, I am using this in my developing > driver;)
yeah, I was just trolling ;)
I queued this fix for 2.6.27.
| |