lkml.org 
[lkml]   [2008]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs
On Sat, 6 Sep 2008, Cyrill Gorcunov wrote:

> So I think better would be just use Ingo's suggestion
> about to separate apic/pin iterator and function body.

No doubt about it. Then if the number of entries was to be huge, then
lines output to the log buffer could be limited to 80 characters. With
the use of sprintf() it would be rather trivial. And you would avoid any
concerns about stack consumption.

Please note that with MPS 1.1 systems the number of "unconnected" I/O
APIC inputs can be considerable.

Maciej


\
 
 \ /
  Last update: 2008-09-06 22:11    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site