Messages in this thread |  | | | Date | Sat, 6 Sep 2008 21:08:51 +0100 (BST) | | From | "Maciej W. Rozycki" <> | | Subject | Re: [patch 3/3] x86: io-apic - code style cleaning for setup_IO_APIC_irqs |
| |
On Sat, 6 Sep 2008, Cyrill Gorcunov wrote:
> So I think better would be just use Ingo's suggestion > about to separate apic/pin iterator and function body.
No doubt about it. Then if the number of entries was to be huge, then lines output to the log buffer could be limited to 80 characters. With the use of sprintf() it would be rather trivial. And you would avoid any concerns about stack consumption.
Please note that with MPS 1.1 systems the number of "unconnected" I/O APIC inputs can be considerable.
Maciej
|  |