Messages in this thread |  | | | Date | Fri, 5 Sep 2008 09:46:04 +0200 | | From | Ingo Molnar <> | | Subject | Re: [PATCH 16/16] x86: use common.c for 64 bit |
| |
* Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> and remove common_64.c > > Signed-off-by: Yinghai <yhlu.kernel@gmail.com> > --- > arch/x86/kernel/cpu/Makefile | 6 +- > arch/x86/kernel/cpu/common_64.c | 1201 --------------------------------------- > 2 files changed, 3 insertions(+), 1204 deletions(-) > delete mode 100644 arch/x86/kernel/cpu/common_64.c
very nice patchset!
I've created a new topic for this: tip/x86/unify-cpu-detect, with these commits:
f5017cf: x86: use cpu/common.c on 64 bit 143b604: x86: cpu/common*.c, merge whitespaces 102bbe3: x86: cpu/common*.c, merge identify_cpu() b89d3b3: x86: cpu/common*.c, merge generic_identify() 56f0d03: x86: cpu/common*.c: merge print_cpu_info() 6627d24: x86: cpu/common*.c, merge early_identify_cpu() 5122c89: x86: cpu/common.c: merge get_cpu_cap() 1cd7877: x86: cpu/common*.c, merge detect_ht() 140fc72: x86: cpu/common*.c, merge display_cacheinfo() b9e67f0: x86: cpu/common.c, merge default_init() fab334c: x86: cpu/common*.c, merge switch_to_new_gdt() 1ba7658: x86: cpu/common*.c have same cpu_init(), with copying and #ifdef d5494d4: x86: cpu/common*.c, make 32-bit have 64-bit only functions ba51dce: x86: cpu/common.c, let 64-bit code have 32-bit only functions 950ad7f: x86: same gdt_page with macro f0fc4af: x86: make header file the same in arch/x86/kernel/cpu/common_xx.c 97e4db7: x86: make detect_ht depend on CONFIG_X86_HT
One small detail: i've added commit 143b604 before the final commit with the whitespace deltas, to make the final commit a pure, mechanic file-delete. The end result is still the same.
btw., the total effect of the unification is:
4 files changed, 433 insertions(+), 861 deletions(-)
which is nice!
Ingo
|  |