lkml.org 
[lkml]   [2008]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [uml-devel] [PATCH 2/6] UML: Don't valgrind userspace
    On Fri, Aug 29, 2008 at 04:15:24PM -0700, Steve VanDeBogart wrote:
    > Add a flag to tell Valgrind to run the forked child natively. Necessary
    > because Valgrind makes additional system calls to instrumented processes,
    > which confuse UML.

    > +#ifdef UML_CONFIG_VALGRIND_SUPPORT
    > + flags |= VALGRIND_CLONE_LETGO;
    > +#endif
    > + }

    I keep forgetting that I have a really bad feeling about this:

    +#define VALGRIND_CLONE_LETGO 0x80000000 /* do not track fork like childr
    en*/
    This is effectively appropriating part of the kernel's ABI for
    valgrind's use. Not to mention that that bit is already taken:

    #define CLONE_IO 0x80000000 /* Clone io context */
    Could you do this with an annotation that says "let the next clone run
    untraced"?

    Jeff

    --
    Work email - jdike at linux dot intel dot com


    \
     
     \ /
      Last update: 2008-09-05 22:49    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean