Messages in this thread | | | Date | Fri, 5 Sep 2008 14:10:50 +0100 | From | Mark Brown <> | Subject | Re: [alsa-devel] [PATCH 2/9] ASoC: Blackfin: SPORT peripheral interface driver |
| |
On Fri, Sep 05, 2008 at 06:21:35PM +0800, Bryan Wu wrote:
> + /* Maybe the dummy buffer descriptor ring is damaged */ > + sport->dummy_rx_desc->next_desc_addr = \ > + (unsigned long)(sport->dummy_rx_desc+1);
Here and elsewhere in this driver you've got continuation characters which aren't need. I've fixed this up locally (and some additional checkpatch/coding standards things) here and in other patches in the series.
Otherwise the patch series looks good to go, thanks - I'm just about to review the codec driver patch that it depends upon.
| |