lkml.org 
[lkml]   [2008]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] HID: fix tty<->hid deadlock
From
Date
On Thu, 04 Sep 2008 17:16:07 +0200, Jiri Slaby said:

> hid_compat_load() runs on the default workqueue, it request_module(), it
> execs modprobe, it exits, tty flushes default workqueue, it hangs, because
> we are still in it.
>
> I haven't run into it since there always was at least one opener of the tty,
> I guess. Could you try the patch below?
>
> --
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> ---
> drivers/hid/hid-core.c | 11 ++++++++++-
> 1 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 92c16e1..18d952a 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c

With this patch applied, the kernel behaves as expected for my config: it
requests a 'modprobe hid_dummy', which prints a nasty message about being
unable to find it on the initrd, and then we continue with the boot.

Thanks for the quick fix...
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2008-09-05 02:07    [W:0.056 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site