lkml.org 
[lkml]   [2008]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/31] cpumask: Provide new cpumask API

* Mike Travis <travis@sgi.com> wrote:

> /* replaces cpumask_t dst = (cpumask_t)src */
> void cpus_copy(cpumask_t dst, const cpumask_t src);

minor namespace nit i noticed while looking at actual usage of
cpus_copy(): could you please rename it cpumask_set(dst, src)?

That streamlines it to have the same naming concept as atomic_set(),
node_set(), zero_fd_set(), etc.

the patch-set looks quite nice otherwise already, the changes are
straightforward and the end result already looks a lot more maintainable
and not fragile at all.

In what way will Rusty's changes differ? Since you incorporate some of
Rusty's changes already, could you please iterate towards a single
patchset which we could then start testing?

Ingo


\
 
 \ /
  Last update: 2008-09-30 11:15    [W:0.149 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site