lkml.org 
[lkml]   [2008]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] UBIFS: allow for sync_fs when read-only
    Date
    From: Adrian Hunter <ext-adrian.hunter@nokia.com>

    sync_fs can be called even if the file system is mounted
    read-only. Ensure the commit is not run in that case.

    Reported-by: Zoltan Sogor <weth@inf.u-szeged.hu>
    Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
    ---
    fs/ubifs/super.c | 19 ++++++++++---------
    1 files changed, 10 insertions(+), 9 deletions(-)

    diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
    index 7e1f3ef..7fd759d 100644
    --- a/fs/ubifs/super.c
    +++ b/fs/ubifs/super.c
    @@ -420,21 +420,22 @@ static int ubifs_sync_fs(struct super_block *sb, int wait)
    int i, ret = 0, err;
    long long bud_bytes;

    - if (c->jheads)
    + if (c->jheads) {
    for (i = 0; i < c->jhead_cnt; i++) {
    err = ubifs_wbuf_sync(&c->jheads[i].wbuf);
    if (err && !ret)
    ret = err;
    }

    - /* Commit the journal unless it has too few data */
    - spin_lock(&c->buds_lock);
    - bud_bytes = c->bud_bytes;
    - spin_unlock(&c->buds_lock);
    - if (bud_bytes > c->leb_size) {
    - err = ubifs_run_commit(c);
    - if (err)
    - return err;
    + /* Commit the journal unless it has too little data */
    + spin_lock(&c->buds_lock);
    + bud_bytes = c->bud_bytes;
    + spin_unlock(&c->buds_lock);
    + if (bud_bytes > c->leb_size) {
    + err = ubifs_run_commit(c);
    + if (err)
    + return err;
    + }
    }

    /*
    --
    1.5.4.1


    \
     
     \ /
      Last update: 2008-09-30 09:51    [W:0.021 / U:121.316 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site