Messages in this thread | | | Date | Tue, 30 Sep 2008 16:29:32 -0700 | From | Gary Hade <> | Subject | Re: [PATCH] mm: show node to memory section relationship with symlinks in sysfs |
| |
On Tue, Sep 30, 2008 at 05:06:08PM +0900, Yasunori Goto wrote: > > > +#ifdef CONFIG_MEMORY_HOTPLUG_SPARSE > > +int register_mem_sect_under_node(struct memory_block *mem_blk) > : > > I think this patch is convenience even when memory hotplug is disabled. > CONFIG_SPARSEMEM seems better than CONFIG_MEMORY_HOTPLUG_SPARSE.
Yes, this would be nice but unfortunately the presence of the memory section directories that are referenced by the symlinks also depend on CONFIG_MEMORY_HOTPLUG_SPARSE being enabled. Removal of the memory hotplug dependency for the code in drivers/base/memory.c will require more than a simple CONFIG_MEMORY_HOTPLUG_SPARSE to CONFIG_SPARSEMEM dependency change. I am still looking at this.
Thanks for the review and testing.
Gary
-- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 garyhade@us.ibm.com http://www.ibm.com/linux/ltc
| |