lkml.org 
[lkml]   [2008]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [uml-devel] [PATCH 4/6] VM: Annotate pagealloc
On Sat, 30 Aug 2008, Pekka Enberg wrote:

> Hi Steve,
>
> On Sat, Aug 30, 2008 at 2:16 AM, Steve VanDeBogart
> <vandebo-lkml@nerdbox.net> wrote:
>> Valgrind annotations for valgrind: memory is addressable once it's been
>> alloced, and unaddressable when it is freed again. Can't use malloc-like
>> and free-like because valgrind considers a malloc-like chunk indivisible.
>>
>> Signed-off-by: Steve VanDeBogart <vandebo-lkml@nerdbox.net>
>> ---
>>
>> Index: linux-2.6.27-rc5/mm/page_alloc.c
>> @@ -1080,6 +1081,7 @@
>> if (!page)
>> goto failed;
>> }
>> + VALGRIND_MAKE_MEM_UNDEFINED(page_address(page), PAGE_SIZE << order);
>
> No SHOUTING macros please, and I think you should just pass page and
> order here and do the calculation elsewhere.

Valgrind provides a header file that defines these annotation functions.
For the ease of tracking changes to this header file, I've made minimal
changes to it (just a couple lines to integrate with Kconfig). If the
interfaces and/or style is objectionable to the kernel community at
large, than we will have to decide to either wrap the interface that
Valgrind provides or modify the header and track changes manually.

--
Steve


\
 
 \ /
  Last update: 2008-09-03 07:27    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site