lkml.org 
[lkml]   [2008]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.6.27-rc5 doesn't boot on a Pavilion laptop
On Wed, 3 Sep 2008, Luiz Fernando N. Capitulino wrote:

> Em Wed, 3 Sep 2008 12:04:58 +0200 (CEST)
> Thomas Gleixner <tglx@linutronix.de> escreveu:
>
> | On Tue, 2 Sep 2008, Luiz Fernando N. Capitulino wrote:
> | > """
> | > PCI: Using ACPI for IRQ routing
> | > DMAR:parse DMAR table failure.
> | > """
> | >
> | > Also, after about 10 minutes I get the same backtrace as reported in
> | > the ticket above... It's the same bug then.
> |
> | Venki found a nasty bug in the clock events code which might be
> | related to this. I found one as well. Can you please apply the combo
> | of those fixes to current mainline and test it ?
>
> Same problem, with or without CONFIG_HPET enabled.
>
> You think the problem you are discussing with Linus - the TSC
> calibration issue - may have anything to do with this?

Dont think so. Your dmesg outputs do not show any sign of that
disease.

Can you try the patch below please ?

Thanks,
tglx
---
kernel/time/tick-broadcast.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
Index: linux-2.6/kernel/time/tick-broadcast.c
===================================================================
--- linux-2.6.orig/kernel/time/tick-broadcast.c
+++ linux-2.6/kernel/time/tick-broadcast.c
@@ -501,9 +501,12 @@ static void tick_broadcast_clear_oneshot
*/
void tick_broadcast_setup_oneshot(struct clock_event_device *bc)
{
- bc->event_handler = tick_handle_oneshot_broadcast;
- clockevents_set_mode(bc, CLOCK_EVT_MODE_ONESHOT);
- bc->next_event.tv64 = KTIME_MAX;
+ /* Set it up only once ! */
+ if (bc->event_handler != tick_handle_oneshot_broadcast) {
+ bc->event_handler = tick_handle_oneshot_broadcast;
+ clockevents_set_mode(bc, CLOCK_EVT_MODE_ONESHOT);
+ bc->next_event.tv64 = KTIME_MAX;
+ }
}

/*



\
 
 \ /
  Last update: 2008-09-03 16:39    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site