lkml.org 
[lkml]   [2008]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 3/3] ide-cd: shorten ide_cd_request_sense_fixup's param list
    Date
    From
    ... since HWGROUP(drive)->rq points to the same rq as in the irq handler. While
    at it, remove stale comment.

    There should be no functionality change resulting from this patch.

    Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
    ---
    drivers/ide/ide-cd.c | 9 ++++-----
    1 files changed, 4 insertions(+), 5 deletions(-)

    diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
    index e41b94d..bf92cd6 100644
    --- a/drivers/ide/ide-cd.c
    +++ b/drivers/ide/ide-cd.c
    @@ -843,12 +843,11 @@ static void ide_cd_restore_request(ide_drive_t *drive, struct request *rq)
    rq->q->prep_rq_fn(rq->q, rq);
    }

    -/*
    - * All other packet commands.
    - */
    -static void ide_cd_request_sense_fixup(ide_drive_t *drive, struct request *rq)
    +static void ide_cd_request_sense_fixup(ide_drive_t *drive)
    {

    + struct request *rq = HWGROUP(drive)->rq;
    +
    ide_debug_log(IDE_DBG_FUNC, "Call %s, rq->cmd[0]: 0x%x\n",
    __func__, rq->cmd[0]);

    @@ -1021,7 +1020,7 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
    cdrom_end_request(drive, uptodate);
    return ide_stopped;
    } else if (!blk_pc_request(rq)) {
    - ide_cd_request_sense_fixup(drive, rq);
    + ide_cd_request_sense_fixup(drive);
    /* complain if we still have data left to transfer */
    uptodate = rq->data_len ? 0 : 1;
    }
    --
    1.5.5.4


    \
     
     \ /
      Last update: 2008-09-29 08:33    [W:0.025 / U:1.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site