lkml.org 
[lkml]   [2008]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] sched: trivial fix for incorrect comments
From
Date
On Sat, 2008-09-27 at 20:10 +0200, Ingo Molnar wrote:
> * Chris Friesen <cfriesen@nortel.com> wrote:
>
> > --- a/kernel/sched.c
> > +++ b/kernel/sched.c
> > @@ -298,9 +298,9 @@ static DEFINE_PER_CPU(struct cfs_rq, init_cfs_rq) ____cacheline_aligned_in_smp;
> > static DEFINE_PER_CPU(struct sched_rt_entity, init_sched_rt_entity);
> > static DEFINE_PER_CPU(struct rt_rq, init_rt_rq) ____cacheline_aligned_in_smp;
> > #endif /* CONFIG_RT_GROUP_SCHED */
> > -#else /* !CONFIG_FAIR_GROUP_SCHED */
> > +#else /* !CONFIG_USER_SCHED */
> > #define root_task_group init_task_group
> > -#endif /* CONFIG_FAIR_GROUP_SCHED */
> > +#endif /* CONFIG_USER_SCHED */
>
> hm, these seem to be fixed already, via:
>
> | commit 9a7e0b180da21885988d47558671cf580279f9d6
> | Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> | Date: Tue Aug 19 12:33:06 2008 +0200
> |
> | sched: rt-bandwidth fixes
>
> is all in tip/master.
>
> (or is perhaps the direction of your patch wrong?)

No I think he got it right, as I vaguely remember fixing it too - now I
know where I left it ;-)

I often leave such trivial comment fixes in whatever patch I'm working
on at that moment.





\
 
 \ /
  Last update: 2008-09-27 20:23    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site