Messages in this thread |  | | | Date | Sat, 27 Sep 2008 12:25:30 +0900 | | From | KAMEZAWA Hiroyuki <> | | Subject | Re: [PATCH 9/12] memcg allocate all page_cgroup at boot |
On Fri, 26 Sep 2008 10:43:36 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > > - VM_BUG_ON(pc->page != page);
> > > + pc = lookup_page_cgroup(page);
> > > + if (unlikely(!pc || !PageCgroupUsed(pc)))
> > > + return;
> > > + preempt_disable();
> > > + lock_page_cgroup(pc);
> > > + if (unlikely(page_mapped(page))) {
> > > + unlock_page_cgroup(pc);
> > > + preempt_enable();
> > > + return;
> > > + }
> > Just for clarification, in what sequence will the page be mapped here?
> > mem_cgroup_uncharge_page checks whether the page is mapped.
> >
I think I saw page_mapped() case (in your shmem/page test.)
I'll check what cause this if I have time.
Thanks,
-Kame
|  |