lkml.org 
[lkml]   [2008]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6] Unified trace buffer
From
Date
On Fri, 2008-09-26 at 14:05 -0400, Steven Rostedt wrote:
> +struct ring_buffer {
> + unsigned long size;
> + unsigned pages;
> + unsigned flags;
> + int cpus;
> + atomic_t record_disabled;
> +
> + struct mutex mutex;
> +
> + /* FIXME: this should be online CPUS */
> + struct ring_buffer_per_cpu *buffers[NR_CPUS];

actually nr_possible makes sense, and you might consider always
allocating buffers (and keeping them for offlined cpus) to avoid massive
allocations/frees cpu-hotplug events.

Mike Travis has been going over the kernel removing constructs like
this, and replacing them with dynamically allocated arrays of
nr_possible.

> +};



\
 
 \ /
  Last update: 2008-09-26 21:17    [W:0.163 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site