[lkml]   [2008]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/3] Add timeout feature
    Takashi Sato wrote:
    > Hi,
    > Ric Wheeler wrote:
    >> Christoph Hellwig wrote:
    >>> On Mon, Sep 08, 2008 at 08:53:37PM +0900, Takashi Sato wrote:
    >>>> The timeout feature is added to "freeze ioctl" to solve a deadlock
    >>>> when the freezer accesses a frozen filesystem. And new ioctl
    >>>> to reset the timeout period is added to extend the timeout period.
    >>>> For example, the freezer resets the timeout period to 10 seconds
    >>>> every 5
    >>>> seconds. In this approach, even if the freezer causes a deadlock by
    >>>> accessing the frozen filesystem, it will be solved by the timeout
    >>>> in 10 seconds and the freezer will be able to recognize that
    >>>> at the next reset of timeout period.
    >>> And as with all previous posting I still fundamentally disagree about
    >>> the need of this functionality. We don't need a timeout for freezing.
    >> I agree with Christoph here, I think that the timeout is unneeded.
    > I think that your concern is that the freezer cannot recognize the
    > occurrence
    > of a timeout and it continues the backup process and the backup data is
    > corrupted finally.
    > If the freezer can recognize it by the unfreeze ioctl's errono, will
    > your concern
    > be solved?
    > If so, I will implement it.
    > Cheers, Takashi
    I think that is certainly part a big part of my concern.

    Also note that the timeout seems to be quite low relative to say the
    standard timeout for a SCSI device (30 seconds worst case).

    In general, I am quite supportive of the patch series and think that
    this is a great addition.



     \ /
      Last update: 2008-09-26 13:01    [W:0.021 / U:5.856 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site