lkml.org 
[lkml]   [2008]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ANNOUNCE] [PATCH] [MTD] Flex-OneNAND MTD Driver available.
Hi

>>
>>
>> > diff -uprN a/include/mtd/mtd-abi.h b/include/mtd/mtd-abi.h
>> > --- a/include/mtd/mtd-abi.h 2008-09-16 20:48:12.000000000 +0530
>> > +++ b/include/mtd/mtd-abi.h 2008-09-24 14:09:06.000000000 +0530
>> > @@ -102,7 +102,11 @@ struct nand_oobinfo {
>> > uint32_t useecc;
>> > uint32_t eccbytes;
>> > uint32_t oobfree[8][2];
>> > +#ifdef CONFIG_MTD_ONENAND
>> > + uint32_t eccpos[128];
>> > +#else
>> > uint32_t eccpos[32];
>> > +#endif
>> > };
>> >
>> > struct nand_oobfree {
>> > @@ -117,7 +121,11 @@ struct nand_oobfree {
>> > */
>> > struct nand_ecclayout {
>> > uint32_t eccbytes;
>> > +#ifdef CONFIG_MTD_ONENAND
>> > + uint32_t eccpos[128];
>> > +#else
>> > uint32_t eccpos[64];
>> > +#endif
>> > uint32_t oobavail;
>> > struct nand_oobfree oobfree[MTD_MAX_OOBFREE_ENTRIES];
>> > };
>
> I do not think stuff like this is going to be accepted because you
> change ABI. You should instead introduce new ioctls or add sysfs
> support and expose this information via sysfs. This is much bigger
> work, but it is needed.
>

Thank you for your kind comments.

Yes that's I concerned it breaks the other NAND ABI. Actually In
OneNAND it doesn't use eccpos since OneNAND controller handle all ECC
functions. we don't need to concern it.

As pages are bigger, it requires more eccpos and other fields are
similar. we need more flexible filed definitions.

Well how do you think that at this time it only describes the 64 bytes
only for temporarily and next time it adds remaining parts if it is
really needed.

Thank you,
Kyungmin Park


\
 
 \ /
  Last update: 2008-09-26 07:33    [from the cache]
©2003-2011 Jasper Spaans