Messages in this thread | | | Date | Thu, 25 Sep 2008 14:54:54 +0800 | From | "Li Yang" <> | Subject | Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module |
| |
On Thu, Sep 25, 2008 at 5:59 AM, Timur Tabi <timur@freescale.com> wrote: > Modify the Freescale Elo / Elo Plus DMA driver so that it can be compiled as > a module. > > The primary change is to stop treating the DMA controller as a bus, and the > DMA channels as devices on the bus. This is because the Open Firmware (OF) > kernel code does not allow busses to be removed, so although we can call > of_platform_bus_probe() to probe the DMA channels, there is no > of_platform_bus_remove(). Instead, the DMA channels are manually probed, > similar to what fsl_elbc_nand.c does. > > Signed-off-by: Timur Tabi <timur@freescale.com> > --- > > v2: updated per comments > > This patch is for the 2.6.28 kernel. This patch exposes a bug in the dmatest > module, so my other patch "dmatest: properly handle duplicate DMA channels" > should be applied if this patch is applied. [snip] > +static void __exit of_fsl_dma_exit(void) > +{ > + of_unregister_platform_driver(&of_fsl_dma_driver); > } > > -subsys_initcall(of_fsl_dma_chan_init); > subsys_initcall(of_fsl_dma_init);
Not a critical problem. But module_init() are preferred for modules.
> +module_exit(of_fsl_dma_exit); > + > +MODULE_DESCRIPTION("Freescale Elo / Elo Plus DMA driver"); > +MODULE_LICENSE("GPL");
Acked-by: Li Yang <leoli@freescale.com>
- Leo
| |